At Sun, 1 Feb 2009 20:30:39 +0100,
Michael Schwingen wrote:
>
> Hi,
>
> this is my first ALSA patch, so I am not sure if this is the right place &
> form to post patches?
Yes. At the next time, please add me to Cc so that it'll reach more
reliably.
> Anyway, here is a patch to enable audio on the Maxdata Favorit 100XS - a
> compact PC sold by German company Maxdata (probably manufactured by FIC,
> Transtec Senyo 600/Belinea o.max XS/Lynx Silent PC MP-I *might* be
> identical, but I have none of those).
>
> The Favorit 100XS uses an Intel 945 chipset with a Realtek HD audio codec
> connected to exactly 2 jacks: one input, and one output jack. Using the
> standard ALSA driver, output is silent.
>
> This patch enables audio input/output on these machines - it is based in
> part on the acer code in the same file.
>
> Signed-off-by: Michael Schwingen <michael@xxxxxxxxxxxxx>
The patch looks almost good but there are a few issues to fix.
First off, please use a unified diff (diff -u) for a patch.
Then, rebase your patch to the latest sound git tree[*] or 2.6.29-rc3
at least.
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
Some stuff in patch_realtek.c in the latest tree was changed to be
incompatible from 2.6.28. For example,
> + [ALC260_FAVORIT100] = {
> + .mixers = { alc260_favorit100_mixer,
> + alc260_capture_mixer },
The capture mixer is now created dynamically. Usually you don't need
pass capture_mixer array here.
> + .init_verbs = { alc260_acer_init_verbs },
Don't you use alc260_favorit100_init_verbs?
Could you fix these and repost?
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
