On Wed, 4 Feb 2009 12:48:34 +0100
Hans-Christian Egtvedt <hans-christian.egtvedt@xxxxxxxxx> wrote:
> This patch adds ALSA support for the AC97 controller found on Atmel
> AVR32 devices.
>
> Tested on ATSTK1006 + ATSTK1000 with a development board with a AC97
> codec.
>
<snipp most of patch>
> +static int __devinit atmel_ac97c_pcm_new(struct atmel_ac97c *chip)
> +{
> + struct snd_pcm *pcm;
> + int capture = test_bit(DMA_RX_CHAN_PRESENT, &chip->flags);
> + int playback = test_bit(DMA_TX_CHAN_PRESENT, &chip->flags);
> + int err;
> +
> + err = snd_ac97_pcm_assign(chip->ac97_bus,
> + ARRAY_SIZE(atmel_ac97_pcm_defs),
> + atmel_ac97_pcm_defs);
Is this call really needed? snd_ac97_pcm_assign() seems to have few
users in ALSA. I do not really get what this does, it is just something
that's always been in the driver.
<snipp>
--
Best regards,
Hans-Christian Egtvedt
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
