On Tuesday 03 February 2009 14:05:08 Mark Brown wrote: > Please do. You should at least include some text in the patch > description explaining what you're doing. One more version of patch, I've fixed patch description, but didn't removed FIXME's, just fixed one comment. Btw, it would be nice to hear Philipp's opinion :) Regards Vasily
From 507528459911f7cc5745274bffd652e2f5302889 Mon Sep 17 00:00:00 2001 From: Vasily Khoruzhick <anarsoul@xxxxxxxxx> Date: Tue, 3 Feb 2009 15:28:35 +0200 Subject: [PATCH] UDA1380 driver should restore UDA1380_CLK register value in uda1380_pcm_prepare instead of enabling R00_DAC_CLK. Without this fix driver switches to WSPLL in uda1380_pcm_prepare even if SYSCLK was chosen (uda1380_pcm_prepare modifies UDA1380_CLK register to disable R00_DAC_CLK before flushing reg cache) Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> --- sound/soc/codecs/uda1380.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/uda1380.c b/sound/soc/codecs/uda1380.c index a69ee72..eba034a 100644 --- a/sound/soc/codecs/uda1380.c +++ b/sound/soc/codecs/uda1380.c @@ -432,8 +432,8 @@ static int uda1380_pcm_prepare(struct snd_pcm_substream *substream) uda1380_write(codec, reg, uda1380_read_reg_cache(codec, reg)); } - /* FIXME enable DAC_CLK */ - uda1380_write(codec, UDA1380_CLK, clk | R00_DAC_CLK); + /* FIXME restore DAC_CLK */ + uda1380_write(codec, UDA1380_CLK, clk); return 0; } -- 1.6.1.1
Attachment:
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
