Re: [PATCH] sscape: drop redundant fields from soundscape struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Sun, 1 Feb 2009 21:12:31 +0100,
Krzysztof Helt wrote:
> 
> The midi_vol is set only to 0 so it does not work
> as detection of change in midi volume. It is removed.

It's used to cache the value.  You should better to keep it, but fix
sscape_midi_put() function to remember the last
uctl->value.integer.value[0] value in this field.
(And also better to change sscape_midi_get() to return midi_vol
 value.)

Other changes look good.


Thanks!

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux