Only one comment from me... On Thu, Jan 15, 2009 at 10:06:53AM +0000, Ian Molton wrote: > diff --git a/sound/soc/codecs/wm9705.c b/sound/soc/codecs/wm9705.c > new file mode 100644 > index 0000000..4ff6a84 > --- /dev/null > +++ b/sound/soc/codecs/wm9705.c > @@ -0,0 +1,401 @@ > +/* > + * wm9705.c -- ALSA Soc WM9705 codec support > + * > + * Copyright 2008 Ian Molton <spyro@xxxxxxx> > + * > + * This program is free software; you can redistribute it and/or > modify it > + * under the terms of the GNU General Public License as published > by the > + * Free Software Foundation; Version 2 of the License only. > + * > + */ > + > +#include <linux/init.h> > +#include <linux/module.h> > +#include <linux/version.h> Please do not include linux/version.h except where it is really needed (I don't see anything requiring it in this file.) _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
