Re: [PATCH] TWL4030: Add event callback to enable hands-free.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 11, 2008 at 09:52:01AM +0800, Stanley.Miao wrote:
> A special sequence is required to enable hands-free on TWL4030.
> 
> Signed-off-by: Stanley.Miao <stanley.miao@xxxxxxxxxxxxx>

I've applied this but I'm a bit nervous about this:

> +	} else {
> +		twl4030_write(w->codec, e->reg, 0x0);
> +	}

since that's clearing bits other than those which were enabled.  It
looks like there aren't any other bits in the register but it'd be good
to be more explicit about this.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux