Re: [PATCH] ALSA: Reduce stall detection timeout in riptide.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Wed, 03 Dec 2008 15:32:15 +0100,
nokos@xxxxxxx wrote:
> 
> Reduce the command timeout to 0.5sec. Should be enough to allow a
> working command interface but removes a RCU stall and slow resume on
> some revisions where the AC97 revision detection stalls in resume. 
> 
> Signed-off-by: Peter Gruber <nokos@xxxxxxx>

Applied.  Sounds like a reasonable workaround until the real culprit
gets fixed.


thanks,

Takashi

> ---
> 
> 
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index e9f0706..d0ccfc6 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -172,7 +172,7 @@
>  
>  #define MAX_WRITE_RETRY  10    /* cmd interface limits */
>  #define MAX_ERROR_COUNT  10
> -#define CMDIF_TIMEOUT    500000
> +#define CMDIF_TIMEOUT    50000
>  #define RESET_TRIES      5
>  
>  #define READ_PORT_ULONG(p)     inl((unsigned long)&(p))
> 
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux