At Mon, 01 Dec 2008 18:32:27 +0100, I wrote: > > At Mon, 1 Dec 2008 17:24:55 +0000, > Mark Brown wrote: > > > > On Mon, Dec 01, 2008 at 06:14:12PM +0100, Takashi Iwai wrote: > > > Mark Brown wrote: > > > > > > Hrm. Which compiler are you using? > > > > > gcc-4.1 for ARM, if I remember correctly... > > > > I'm at 4.2.4 for ARM. > > > > > > The WM8903 warning patch you > > > > introduced is not needed on any of my systems (primarily ARM and > > > > x86-64). It smells like a problem with the BUG() definition on your > > > > platform... > > > > > Possibly. I'm not pretty sure on which systems, since I run test-builds > > > regularly for ARM, PPC, x86 and x86-64 with cross compilers. > > > > Could you investigate, please? I'd rather not add annotations like that > > since they mask genuine compiler warnings and are liable to crop up > > elsewhere. That particular function isn't likely to change but I'm > > worried in case this sort of thing starts cropping up elsewhere. > > > > For that particular function I'd rather add return statements after the > > BUG()s... > > Yes, this would work, too. > > > As far as I'm aware the current ASoC code is warning free. > > OK, I'll test through all builds again. Through all builds, I couldn't reproduce the warnings again. So I reverted the commit. Sorry for noises. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
