On Wed, Nov 26, 2008 at 3:08 AM, Mark Brown <broonie@xxxxxxxxxxxxx> wrote: > On Wed, Nov 26, 2008 at 06:47:58PM +0800, Stanley.Miao wrote: >> Add a shared omap SoC driver to avoid reduplicate code among omap soc drivers. > > It's really good to see work on this but I've got some concerns with the > approach being taken here. I too have concerns. The SoC drivers are very much alike at the moment because only the minimum subset of twl4030 functionality is supported. As we flesh out the twl4030 features (see the other twl4030 codec driver threads on this list) I expect the machine specific drivers to begin to diverge (radically in some cases) based upon the hardware features of each. I'm all for factoring out common code, but I think that this approach will become a maintenance nightmare over time. Steve _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
