At Thu, 20 Nov 2008 20:31:16 -0500,
Matthew Ranostay wrote:
>
> Takashi Iwai wrote:
> > At Wed, 19 Nov 2008 21:48:51 -0500,
> > Matthew Ranostay wrote:
> >> Add PCI quirk STAC_DELL_M4_3 for 92hd71bxx based laptops.
> >
> > Which laptops, more exactly? Recently I received bug reports about
> > Dell Studio laptops, and wondering whether it's for such models.
> >
> >
> >> @@ -4650,14 +4661,20 @@ again:
> >>
> >> switch (spec->board_config) {
> >> case STAC_HP_M4:
> >> - spec->num_dmics = 0;
> >> - spec->num_smuxes = 0;
> >> - spec->num_dmuxes = 0;
> >> -
> >> /* enable internal microphone */
> >> stac92xx_set_config_reg(codec, 0x0e, 0x01813040);
> >> stac92xx_auto_set_pinctl(codec, 0x0e,
> >> AC_PINCTL_IN_EN | AC_PINCTL_VREF_80);
> >
> > Please add a comment about fall-through here.
> >
> > Also, update Documentation/*/ALSA-Configuration.txt as well.
> >
> >
> > thanks,
> >
> > Takashi
> >
>
> Add PCI quirk STAC_DELL_M4_3 for 92hd71bxx based laptops and desktops.
>
> Signed-off-by: Matthew Ranostay <mranostay@xxxxxxxxxxxxxxxxx>
Thanks. Now another questions about the patch.
> @@ -4650,14 +4661,21 @@ again:
>
> switch (spec->board_config) {
> case STAC_HP_M4:
> - spec->num_dmics = 0;
> - spec->num_smuxes = 0;
> - spec->num_dmuxes = 0;
> -
Any reason to remove these....
> /* enable internal microphone */
> stac92xx_set_config_reg(codec, 0x0e, 0x01813040);
> stac92xx_auto_set_pinctl(codec, 0x0e,
> AC_PINCTL_IN_EN | AC_PINCTL_VREF_80);
> + /* fallthru */
> + case STAC_DELL_M4_2:
> + spec->num_dmics = 0;
> + spec->num_smuxes = 0;
> + spec->num_dmuxes = 0;
> + break;
> + case STAC_DELL_M4_1:
> + case STAC_DELL_M4_3:
> + spec->num_dmics = 1;
> + spec->num_smuxes = 0;
> + spec->num_dmuxes = 0;
... and adding these?
That is, the patch introduces more changes than its description.
If you change or fix the behavior of other models, please split, or
at least give a proper changelog.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
