On Thu, Nov 20, 2008 at 3:51 AM, naveen krishna ch <naveenkrishna.ch@xxxxxxxxx> wrote: > On Thu, Nov 20, 2008 at 4:53 PM, Mark Brown <broonie@xxxxxxxxxxxxx> wrote: >> As I said in reply to your first mail I'd really like to see some sort >> of explanation as to why you are making these changes - are the defaults >> in the existing driver wrong? There seem to be an awful lot of changes >> here and there's no discussion in the patch as to what they mean. > > The existing driver does the default settings for only one input device > (Line in) and one output device (Headset out). > The CODEC supports 5 output devices and 4 input devices. > > The default values given by the drivers author are according to his custom > requirements, expanding them to the CODEC's ability these values can be > modified. > > What all this patch is doing is setting the default playback and capture > volumes of various input and output devices to reasonable values. These seem like reasonable default values for features the driver previously did not use. Couldn't verify that there are no side effects by build & run testing since the patch wouldn't apply for me. Steve _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
