>> sport_handle is a global and not allocated my kmalloc. > >There's no reference to sport_handle in the patch... Sorry - spurious comment please ignore. -Michael >-----Original Message----- >From: Mark Brown [mailto:broonie@xxxxxxxxxxxxx] >Sent: Tuesday, November 18, 2008 12:54 PM >To: Bryan Wu >Cc: tiwai@xxxxxxx; Cliff Cai; alsa-devel@xxxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; Michael Hennerich >Subject: Re: [PATCH 5/8] ASoC: Fix BUGS in Blackfin AC97 DAI > >On Tue, Nov 18, 2008 at 04:18:19PM +0800, Bryan Wu wrote: >> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > >> sport_handle is a global and not allocated my kmalloc. > >There's no reference to sport_handle in the patch... > >> A probe function should have a clean return 0 path. > >...only this. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
