Yes, that can add supported sample rates. but the macro definitions are still needed, actually 12000 and 24000 are supported by most audio codecs. in soc-core.c runtime->hw.rates = codec_dai->capture->rates & cpu_dai->capture->rates; in wm8350.c #define WM8350_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 | \ SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 | \ SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_32000 | \ SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 | \ SNDRV_PCM_RATE_96000) static const struct snd_soc_pcm_stream wm8350_hifi_dai_playback = { .stream_name = "Playback", .channels_min = 2, .channels_max = 2, .rates = WM8350_RATES, .formats = WM8350_FORMATS, }; Without the mcaro defintions, it is hard to handle the 12000 and 24000 sample rates. 2008/11/14 cocala <syy.wxd@xxxxxxxxx> > Who can tell me why not define add SNDRV_PCM_RATE_24000 and > SNDRV_PCM_RATE_12000? _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel