Re: [PATCH] aoa i2sbus: don't overwrite module parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-10-23 at 18:47 +0200, Takashi Iwai wrote:
> At Thu, 23 Oct 2008 13:57:39 +0200,
> Johannes Berg wrote:
> > 
> > We shouldn't modify a global variable here.
> > 
> > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> 
> Applied.  This seems a good thing to go to 2.6.28, so I'll put
> it to the next pull request.

Heh, well, it doesn't _really_ matter, it's just cleaner for reporting
to userspace via sysfs what the module parameters are. It's been that
way since I wrote it over two years ago, so ... up to you, I don't
really care.

Thanks for taking it.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux