On Mon, Oct 20, 2008 at 05:40:22PM -0400, Matthew Ranostay wrote: > Add support for reporting line out, headphone, and microphone jack insertions > via the jack abstraction layer for the Sigmatel/IDT codec family. The jack detection side of this looks good - I've not really reviewed the HDA side of things. One comment: > + if (type == SND_JACK_SWITCH) > + type = (pin_ctl & AC_PINCTL_HP_EN) > + ? SND_JACK_HEADPHONE : SND_JACK_LINEOUT; So SND_JACK_SWITCH is just a jack that can be either headphone or lineout - like I said previously, you should not define a new jack type for this but just set both jack types when registering the jack. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
