On Thu, Mar 13, 2025 at 05:32:38PM +0800, Shenghao Ding wrote: > For calibration, basic version does not contain any calibration addresses, > it depends on calibration tool to convey the addresses to the driver. > Since Alpha and Beta firmware, all the calibration addresses are saved > into the firmware. I believe there is a lot of room to improve in this patch and in the entire driver, but this probably is needed to unblock the users. So, from my point of view if it's working, it's good enough to go. FWIW, Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko