> -----Original Message----- > From: Takashi Iwai <tiwai@xxxxxxx> > Sent: Wednesday, March 5, 2025 4:50 PM > To: Kailang <kailang@xxxxxxxxxxx> > Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx>; > linux-sound@xxxxxxxxxxxxxxx > Subject: Re: update ALC222 depop optimize > > > External mail : This email originated from outside the organization. Do not > reply, click links, or open attachments unless you recognize the sender and > know the content is safe. > > > > On Wed, 05 Mar 2025 09:22:20 +0100, > Kailang wrote: > > > > > > > > > -----Original Message----- > > > From: Takashi Iwai <tiwai@xxxxxxx> > > > Sent: Wednesday, March 5, 2025 4:17 PM > > > To: Kailang <kailang@xxxxxxxxxxx> > > > Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx>; > > > linux-sound@xxxxxxxxxxxxxxx > > > Subject: Re: update ALC222 depop optimize > > > > > > > > > External mail : This email originated from outside the organization. > > > Do not reply, click links, or open attachments unless you recognize > > > the sender and know the content is safe. > > > > > > > > > > > > On Wed, 05 Mar 2025 08:56:41 +0100, > > > Kailang wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Takashi Iwai <tiwai@xxxxxxx> > > > > > Sent: Wednesday, March 5, 2025 3:54 PM > > > > > To: Kailang <kailang@xxxxxxxxxxx> > > > > > Cc: (alsa-devel@xxxxxxxxxxxxxxxx) <alsa-devel@xxxxxxxxxxxxxxxx>; > > > > > linux-sound@xxxxxxxxxxxxxxx > > > > > Subject: Re: update ALC222 depop optimize > > > > > > > > > > > > > > > External mail : This email originated from outside the organization. > > > > > Do not reply, click links, or open attachments unless you > > > > > recognize the sender and know the content is safe. > > > > > > > > > > > > > > > > > > > > On Wed, 05 Mar 2025 07:32:00 +0100, Kailang wrote: > > > > > > > > > > > > Hi Takashi, > > > > > > > > > > > > Update ALC222 depop optimize as attach. > > > > > > > > > > Could you give a bit more background info why this change is needed? > > > > > Is it a mandatory change to fix something, or it improves something? > > > > > > > > > This codec has two headphone design. > > > > The HP2 was nid 0x14. > > > > > > Sorry not clear enough: do you mean the patch is to fix the depop > > > problems on the models with two headphone pins with ALC222? > > > > Yes, the original depop was only supported one headphone. > > OK, and then would it be a bit risky to blindly assume the second headphone > pin 0x14? Isn't it set up via pin config? > It doesn't have risk to set this pin as headphone or line out. This pin (0x14) can be a line out or headphone. It has JD which driver will get it. Line out and Headhpone were need to do depop procedure. If pin 0x14 set to speaker, it wouldn't have JD. hp2_pin_sense = snd_hda_jack_detect(codec, 0x14); This just got JD to do depop. > > thanks, > > Takashi
