On 07/02/25 19:02, Mark Brown wrote: > On Fri, Feb 07, 2025 at 11:58:10AM +0530, Vijendar Mukunda wrote: > >> + if (adata->acp_rev == ACP63_PCI_REV) { >> + } else { > Unless I find something major in the rest of the series I'll apply this > but it's much better to write these as case statements, that way if you > get additional types to handle it's easier to extend the code sensibly. > Please update this incrementally. Will push it as an incremental patch.