On 23/12/24 11:38, Vinod Koul wrote: > On 03-12-24, 14:40, Vijendar Mukunda wrote: > > for...? Pls write the full subject Patch commit title was not updated properly. I have already respin the patch by updating the subject. Sent a mail to ignore this patch as commit message is incomplete. > >> As per design for power off mode, clear the wake enable register during >> resume sequence. >> >> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx> >> --- >> drivers/soundwire/amd_manager.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c >> index 5a4bfaef65fb..96a3aa6da711 100644 >> --- a/drivers/soundwire/amd_manager.c >> +++ b/drivers/soundwire/amd_manager.c >> @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) >> if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { >> return amd_sdw_clock_stop_exit(amd_manager); >> } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { >> + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance)); > no need for 0x for a zero value Will fix it and post v2 version. > >> val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL); >> if (val) { >> val |= AMD_SDW_CLK_RESUME_REQ; >> -- >> 2.34.1