Hi! > [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] > > This patch checks if div is less than or equal to zero (div <= 0). If > div is zero or negative, the function returns -EINVAL, ensuring the > division operation (*prate / div) is safe to perform. Well, previous version propagated error code, now it is eaten. Is stm32_sai_get_clk_div returning 0? BR, Pavel > Signed-off-by: Luo Yifan <luoyifan@xxxxxxxxxxxxxxxxxxxx> > Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@xxxxxxxxxxxxxxxxxxxx > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > --- > sound/soc/stm/stm32_sai_sub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c > index 3aa1cf2624020..3a7f0102b4c5c 100644 > --- a/sound/soc/stm/stm32_sai_sub.c > +++ b/sound/soc/stm/stm32_sai_sub.c > @@ -380,8 +380,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, > int div; > > div = stm32_sai_get_clk_div(sai, *prate, rate); > - if (div < 0) > - return div; > + if (div <= 0) > + return -EINVAL; > > mclk->freq = *prate / div; > -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: PGP signature
