On Sun, Sep 29, 2024 at 08:15:22PM -0500, Gax-c wrote: > A 'devm_kzalloc' in 'asoc_qcom_lpass_cpu_platform_probe' could possibly return NULL pointer. > NULL Pointer Dereference may be triggerred in 'asoc_qcom_lpass_cpu_platform_probe' without addtional check. > Add a null check for the returned pointer. > Your description and patch looks good to me. But please run git log on the changed file and add a prefix to your subject to match other changes to this file, and please wrap your commit message at 75 characters. A good resource to read about this is: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format Please also use the form devm_kzalloc() instead of 'devm_kzalloc' when referring to kernel functions. It seems reasonable to mark this for backporting to stable, so I'd also suggest adding the following tag: Cc: stable@xxxxxxxxxxxxxxx > Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") > Signed-off-by: Zichen Xie <zichenxie0106@xxxxxxxxx> > Reported-by: Zichen Xie <zichenxie0106@xxxxxxxxx> > Reported-by: Zijie Zhao <zzjas98@xxxxxxxxx> > Reported-by: Chenyuan Yang <chenyuan0y@xxxxxxxxx> > --- > sound/soc/qcom/lpass-cpu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c > index 5a47f661e0c6..a8e56f47f237 100644 > --- a/sound/soc/qcom/lpass-cpu.c > +++ b/sound/soc/qcom/lpass-cpu.c > @@ -1243,6 +1243,9 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) > drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), > GFP_KERNEL); > Please drop this empty line. Regards, Bjorn > + if (!drvdata->i2sctl) > + return -ENOMEM; > + > /* Initialize bitfields for dai I2SCTL register */ > ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl, > drvdata->lpaif_map); > -- > 2.25.1 > > > > >
