On 16/09/2024 14:32:05+0300, Andrei Simion wrote:
> On 16.09.2024 12:59, Alexandre Belloni wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On 16/09/2024 11:52:15+0300, Andrei Simion wrote:
> >> From: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>
> >>
> >> Drop S24_LE format because it is not supported if more than 2 channels
> >> (of TDM slots) are used. This limitation makes it impractical for use cases
> >> requiring more than 2 TDM slots, leading to potential issues in
> >> multi-channel configurations.
> >>
> >> [andrei.simion@xxxxxxxxxxxxx: Reword the commit title and the commit
> >> message.]
> >>
> >> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>
> >> Signed-off-by: Andrei Simion <andrei.simion@xxxxxxxxxxxxx>
> >> ---
> >> sound/soc/atmel/atmel_ssc_dai.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> >> index 7047f17fe7a8..475e7579c64c 100644
> >> --- a/sound/soc/atmel/atmel_ssc_dai.c
> >> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> >> @@ -822,7 +822,7 @@ static int atmel_ssc_resume(struct snd_soc_component *component)
> >> }
> >>
> >> #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\
> >> - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
> >> + SNDRV_PCM_FMTBIT_S32_LE)
> >
> > I believe this requires a comment. Else someone may add it back later
> > on.
> >
>
> It is unclear to me. Would it be good to send v2 with this update?
>
Yes, please send a new version. My point is that it is explained in the
commit log. This is fine when you are adding something because then
people will easily use git blame and find the commit and log. However,
because you are removing code, it is not obvious there is a reason why
it isn't there;
> >>
> >> static const struct snd_soc_dai_ops atmel_ssc_dai_ops = {
> >> .startup = atmel_ssc_startup,
> >> --
> >> 2.34.1
> >>
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
>
> Best regards,
> Andrei Simion
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
