On Fri, Sep 13, 2024 at 10:12:39PM +0100, Hugh Cole-Baker wrote: > I added printk to show the value of AUD_CONF2, and found that on 6.1.23, the > value is 0 before the code in this patch sets the insert_pcuv bit. On 6.10.3 > the value is 4, i.e. insert_pcuv is already set. > > According to the RK3399 TRM, the value-after-reset of the insert_pcuv bit is 1, > so apparently on the 6.1.23 kernel something is clearing the bit after HW reset > but before this driver sets the hw_params, and this patch sets it back to the > correct value. On 6.10.3 the bit is not cleared, i.e. this patch is seemingly > no longer necessary (but is a harmless no-op). Hi Hugh, Thank you for your extensive testing. It seems then there's no action we need to take for mainline, as it's already fixed there. > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-20221017.h > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-20221017.h > > btw, this patch doesn't apply without edits as these filenames are incorrect. > Yeah, I see. My bad. Thank you, Geraldo Nascimento
