On Tue, Sep 10, 2024 at 04:02:29PM +0300, Péter Ujfalusi wrote: > Hi, > > On 10/09/2024 15:40, Peter Ujfalusi wrote: > > The prop->src_dpn_prop and prop.sink_dpn_prop is allocated for the _number_ > > of ports and it is forced as 0 index based. > > > > The original code was correct while the change to walk the bits and use > > their position as index into the arrays is not correct. > > > > For exmple we can have the prop.source_ports=0x2, which means we have one > > port, but the prop.src_dpn_prop[1] is accessing outside of the allocated > > memory. > > > > This reverts commit 6fa78e9c41471fe43052cd6feba6eae1b0277ae3. > > I just noticed that Krzysztof already sent the revert patch but it is > not picked up for stable-6.10.y > > https://lore.kernel.org/lkml/20240909164746.136629-1-krzysztof.kozlowski@xxxxxxxxxx/ Is this in Linus's tree yet? That's what we are waiting for. > > Cc: stable@xxxxxxxxxxxxxxx # 6.10.y > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> > > --- > > Hi, > > > > The reverted patch causes major regression on soundwire causing all audio > > to fail. > > Interestingly the patch is only in 6.10.8 and 6.10.9, not in mainline or linux-next. Really? Commit ab8d66d132bc ("soundwire: stream: fix programming slave ports for non-continous port maps") is in Linus's tree, why isn't it being reverted there first? confused, greg k-h
