On 10-09-24, 16:49, Péter Ujfalusi wrote: > > > On 10/09/2024 16:05, Péter Ujfalusi wrote: > > > > > > On 09/09/2024 19:47, Krzysztof Kozlowski wrote: > >> This reverts commit ab8d66d132bc8f1992d3eb6cab8d32dda6733c84 because it > >> breaks codecs using non-continuous masks in source and sink ports. The > >> commit missed the point that port numbers are not used as indices for > >> iterating over prop.sink_ports or prop.source_ports. > >> > >> Soundwire core and existing codecs expect that the array passed as > >> prop.sink_ports and prop.source_ports is continuous. The port mask still > >> might be non-continuous, but that's unrelated. > >> > >> Reported-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> > >> Closes: https://lore.kernel.org/all/b6c75eee-761d-44c8-8413-2a5b34ee2f98@xxxxxxxxxxxxxxx/ > >> Fixes: ab8d66d132bc ("soundwire: stream: fix programming slave ports for non-continous port maps") > >> Acked-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> > >> Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > >> Cc: <stable@xxxxxxxxxxxxxxx> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > Tested-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> > > Vinod: can you pick this patch for 6.11 if there is still time since > upstream is also broken since 6.11-rc6 Done, should be sent to Linus tomorrow... -- ~Vinod
