On Tue, Sep 03, 2024 at 02:44:34PM +0900, Kiseok Jo wrote: > Signed-off-by: Kiseok Jo <kiseok.jo@xxxxxxxxxxxxxx> Empty commit? Read submitting-patches. Please run scripts/checkpatch.pl and fix reported warnings. Then please run and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > --- Where is the changelog? What happened in v2? Why are you sending the same patch? > .../bindings/sound/irondevice,sma1307.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml > > diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml > new file mode 100644 > index 000000000..0bb4ee664 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/irondevice,sma1307.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Iron Device SMA1307 Audio Amplifier > + > +maintainers: > + - Kiseok Jo <kiseok.jo@xxxxxxxxxxxxxx> > + > +description: > + SMA1307 boosted digital speaker amplifier > + with feedback-loop. > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + enum: > + - irondevice,sma1307a > + - irondevice,sma1307aq > + description: > + If a 'q' is added, it indicated the product is AEC-Q100 > + qualified for automotive applications. SMA1307A supports > + both WLCSP and QFN packages. However, SMA1307AQ only > + supports the QFN package. Difference is only in package bin? That does not warrant new compatible. Best regards, Krzysztof
