On Sat, Aug 24, 2024 at 02:05:00PM +0800, Shenghao Ding wrote: > Replace devm_kzalloc and scnprintf with devm_kstrdup. We refer to the functions as func(). Please, fix this in the Subject and commit message. ... > + conf_name = devm_kstrdup(tas_priv->dev, "Speaker Config Id", > + GFP_KERNEL); Can be squeezed to a single line. ... Other than above, LGTM. -- With Best Regards, Andy Shevchenko