On Wed, Aug 21, 2024 at 11:23:24PM +0000, Kuninori Morimoto wrote: > > > No driver is calling snd_soc_dpcm_can_be_xxx() functions. We don't need > > > to have EXPORT_SYMBOL_GPL() for them. Let's makes it static function. > > > One note is that snd_soc_dpcm_fe_can_update() is not used in upstream. > > > Use #if-endif and keep it for future support. > > We should just delete the code if it's not needed, it can always be > > re-added later. > The reason why this patch try to keep the code is that 2 functions > (for fe/be) determination methods are unique. But be is used, fe is not > used. > snd_soc_dpcm_fe_can_update() > snd_soc_dpcm_be_can_update() > Of cource we can remove it and re-added later, but I'm afraid the person > who will re-add it might not noticed that there was a code before, and > re-add different determination methods, etc. > To avoid such things, this patch disables it by #if-endif. > But I can post v3 patch which doesn't have unneeded code. > Please let me know which one is better. I can see the symmetry argument, I don't know how other people working more with DPCM feel though? I think either the function should be removed or it should be left with in #if 0, it's those that are the issue with the change.
Attachment:
signature.asc
Description: PGP signature
