Re: [PATCH v1] ASoc: tas2781: fixed the issue that the chip do not shutdown immediatly after aplay stopped

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 19, 2024 at 10:10:12PM +0800, Shenghao Ding wrote:
> Issue reported from customer that the chip do not shutdown after aplay
> stopped until 6 mins later. Drop tasdevice_dapm_event and implement
> .stream_mute in the tasdevice_dai_ops.

Six minutes sounds like a usersrpace issue with userspace sitting
playing silence for a long time rather than a driver issue.  By default
DAPM does defer powerdown, but only by seconds not minutes.

> -	/* Codec Lock Release*/
> -	mutex_unlock(&tas_priv->codec_lock);
> +	/* Codec Lock/UnLock */
> +	guard(mutex)(&tas_priv->codec_lock);
> +	tasdevice_tuning_switch(tas_priv, mute);

This is a much heavier weight operation than we're expecting for a mute,
it should usually just be literally muting - one or two register writes,
not a power up/down sequence

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux