Hi Andy > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Sent: Thursday, August 15, 2024 8:04 PM > To: Ding, Shenghao <shenghao-ding@xxxxxx> > Cc: broonie@xxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre- > louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; zhourui@xxxxxxxxxx; > alsa-devel@xxxxxxxxxxxxxxxx; Salazar, Ivan <i-salazar@xxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; Chadha, Jasjot Singh <j-chadha@xxxxxx>; > liam.r.girdwood@xxxxxxxxx; Yue, Jaden <jaden-yue@xxxxxx>; yung- > chuan.liao@xxxxxxxxxxxxxxx; Rao, Dipa <dipa@xxxxxx>; yuhsuan@xxxxxxxxxx; > Lo, Henry <henry.lo@xxxxxx>; tiwai@xxxxxxx; Xu, Baojun <baojun.xu@xxxxxx>; > soyer@xxxxxx; Baojun.Xu@xxxxxxx; judyhsiao@xxxxxxxxxx; Navada Kanyana, > Mukund <navada@xxxxxx>; cujomalainey@xxxxxxxxxx; Kutty, Aanya > <aanya@xxxxxx>; Mahmud, Nayeem <nayeem.mahmud@xxxxxx>; > savyasanchi.shukla@xxxxxxxxxxxxx; flaviopr@xxxxxxxxxxxxx; Ji, Jesse <jesse- > ji@xxxxxx>; darren.ye@xxxxxxxxxxxx; antheas.dk@xxxxxxxxx; > Jerry2.Huang@xxxxxxxxxxxxxxxxxx > Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Rename dai_driver > name to unify the name between TAS2563 and TAS2781 > > On Thu, Aug 15, 2024 at 03: 02: 01AM +0000, Ding, Shenghao wrote: > > From: > Andy Shevchenko <andriy. shevchenko@ linux. intel. com> > > Sent: Monday, > August 12, 2024 11: 52 PM > > On Sat, Aug 03, 2024 at 11: 27: 14AM +0800, > Shenghao ZjQcmQRYFpfptBannerStart This message was sent from outside of > Texas Instruments. > Do not click links or open attachments unless you recognize the source of this > email and know the content is safe. > <https://us-phishalarm- > ewt.proofpoint.com/EWT/v1/G3vK!uBdnVVfn3ofU5Y7otlzPNHz8qK- > 2IJyfkpc722d3LxLdT3TGK8e6EW9B1-j1y1PtAwEKJhr-ue39zDQ-QZA$> > Report Suspicious > > ZjQcmQRYFpfptBannerEnd > On Thu, Aug 15, 2024 at 03:02:01AM +0000, Ding, Shenghao wrote: > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > Sent: Monday, August 12, 2024 11:52 PM On Sat, Aug 03, 2024 at > > > 11:27:14AM +0800, Shenghao Ding wrote: > > ... > > > > > + strscpy(name, "Speaker Profile Id", > > > SNDRV_CTL_ELEM_ID_NAME_MAXLEN); > > > > > > > + strscpy(prog_name, "Speaker Program Id", > > > > + SNDRV_CTL_ELEM_ID_NAME_MAXLEN); > > > > > > > + strscpy(conf_name, "Speaker Config Id", > > > > +SNDRV_CTL_ELEM_ID_NAME_MAXLEN); > > > > > > Why not 2-parameter strscpy()? > > strscpy seemed not support 2 params. Do you mean strcpy? > > 1. It does. > 2. No, I meant strscpy(). I have tried 2-parameter strscpy(), and occurred compiling issue. The first parameter of strscpy, *dst, must be array, but in this code prog_name and conf_name are points to the memories applied by devm_kcalloc. > > -- > With Best Regards, > Andy Shevchenko >
