[PATCH] ASoC: codecs: ES8326: Adjust buttons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > To adapt to chrome, we have adjusted the buttons to match the system.
> 
> >  	case 0x4b:
> >  		/* button volume up */
> > -		cur_button = SND_JACK_BTN_1;
> > +		cur_button = SND_JACK_BTN_2;
> >  		break;
> >  	case 0x27:
> >  		/* button volume down */
> > -		cur_button = SND_JACK_BTN_2;
> > +		cur_button = SND_JACK_BTN_3;
> >  		break;
> 
> This is really problematic, we're changing the keys reported here in a
> way that's not ABI compatible.  If this was a new driver then fine but
> this is quite old, it's in LTS releases, so we might be disrupting
> people's existing systems.  I'm not sure we have a good solution for
> this at this point, we're not even swapping the buttons here but rather
> using a different set of buttons.  Probably ChromeOS needs to work
> around this somehow, or we need to add some mechanism which allows
> userspace to configure the driver mapping at runtime.


We'll use a different method to solve this issue.thank you 



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux