On 09/08/24 13:05, Mark Brown wrote: > On Fri, Aug 09, 2024 at 07:30:54AM +0530, Mukunda,Vijendar wrote: >> On 09/08/24 01:02, Mark Brown wrote: >>> /build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘acp_irq_handler’: >>> /build/stage/linux/sound/soc/sof/amd/acp.c:407:26: error: ‘struct acp_dev_data’ h >>> as no member named ‘pci_rev’ >>> 407 | if (adata->pci_rev >= ACP_RMB_PCI_ID) >>> | ^~ >> This patch is part of https://github.com/thesofproject/linux/pull/5103 >> which got successfully merged into sof github without any build errors. >> This patch is dependent on >> Link: https://patch.msgid.link/20240801111821.18076-10-Vijendar.Mukunda@xxxxxxx >> which got already merged in to ASoC tree for-next base. >> It shouldn't cause build error if the dependent patch already merged. > Are the patches it depends on actually before it in the patch series? > We want the resulting git tree to be bisectable, that means testing each > commit not just the final result. This patch series is prepared on top of 20240801111821.18076-1-Vijendar.Mukunda@xxxxxxx which are incremental changes and also has dependency. As 20240801111821.18076-1-Vijendar.Mukunda@xxxxxxx got merged into for-next branch, compiling this patch series,which is prepared on top of it(20240801111821.18076-1-Vijendar.Mukunda@xxxxxxx), shouldn't trigger any build failures. Within this patch series (20240807051341.1616925-1-Vijendar.Mukunda@xxxxxxx), few patches are dependent patches, as changes are incremental. That's why I have resent whole patch series with cover letter again (20240808165753.3414464-1-Vijendar.Mukunda@xxxxxxx) so that whole patch series can be merged at one go. Each commit can be buildable sequentially.
