Hi Takashi, Thank you for your quick answer, I am not that fast ;-) >At the next time, it'd be appreciate if you post the patch itself,>then we can review and give comments on the code in a reply.>Even if it's too big, you can split to several pieces. Ok. >Just checking it now, and soon found out that many components look>similar as AW2. We have already AW2 driver (whose authors cc'ed).>Can you reuse the code? Hm, I'm afraid not at his point. The existing AW2 driver is IMHO a verystraight-forward implementation - with focus on AW2 - and does not provide generic code parts (apart saa7146 register addr. definitions) for reuse. Maybe that's why it has its own directory not named afterthe chipset?Besides that I have put much emphasis on providing an abstraction-layerfor saa7146 chipset audio functionality, on top of which the audiowerkspecific stuff is built. Hence it does not make much sense to me tryingto reuse code of the existing AW2 driver. I hope you see my point and would appreciate your opinion on this. regards, Matthias ----Ursprüngliche Nachricht----Von: tiwai@xxxxxxxxxxxx: 19.09.2008 17:55An: <matthias.nyffenegger@xxxxxxxxxx>Kopie: "Cedric Bregardis"<cedric.bregardis@xxxxxxx>, "Jean-Christian Hassler"<jhassler@xxxxxxx>, <alsa-devel@xxxxxxxxxxxxxxxx>Betreff: Re: [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver At Fri, 19 Sep 2008 09:10:00 +0000 (GMT),matthias.nyffenegger@xxxxxxxxxx wrote:> > From: Matthias Nyffenegger <matthias.nyffenegger@xxxxxxxxxx>> > Low-level ALSA driver for Emagic Audiowerk8 sound card.> Project page: http://sourceforge.net/projects/aw8-alsa First off, thanks for your patch. At the next time, it'd be appreciate if you post the patch itself,then we can review and give comments on the code in a reply.Even if it's too big, you can split to several pieces. > Built and tested with Vanilla 2.6.25.16, ALSA 1.0.14a.> > Signed-off-by: Matthias Nyffenegger <matthias.nyffenegger@xxxxxxxxxx>> ---> This is a request for submission to ALSA-tree.> URL: http://downloads.sourceforge.net/aw8-alsa/aw-alsa-patch-0.2 Just checking it now, and soon found out that many components looksimilar as AW2. We have already AW2 driver (whose authors cc'ed).Can you reuse the code? thanks, Takashi _______________________________________________Alsa-devel mailing listAlsa-devel@xxxxxxxxxxxxxxxxxxxx://mailman.alsa-project.org/mailman/listinfo/alsa-devel
