On Sat, Jul 27, 2024 at 08:20:24PM GMT, Adam Skladowski wrote: > From: Vladimir Lypak <vladimir.lypak@xxxxxxxxx> > > Add support for configuring Quinary Mi2S interface > it will be used on MSM8953 and MSM8976 platform. > > Signed-off-by: Vladimir Lypak <vladimir.lypak@xxxxxxxxx> > [Adam: Split from MSM8953 support patch,add msg] > Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx> > --- > sound/soc/qcom/apq8016_sbc.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) [...] > > @@ -320,6 +331,9 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev) > if (IS_ERR(data->spkr_iomux)) > return PTR_ERR(data->spkr_iomux); > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "quin-iomux"); > + data->quin_iomux = devm_ioremap_resource(&pdev->dev, res); This will still print an error if there is no quin-iomux. It's better to call devm_ioremap_resource() only if res is not NULL. LGTM otherwise > + > snd_soc_card_set_drvdata(card, data); > > add_ops(card); > -- > 2.45.2 > -- With best wishes Dmitry
