Re: [RFC v2 00/xx] ALSA: ALSA: add snd_pcm_is_playback/capture()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne 24. 07. 24 v 3:59 Kuninori Morimoto napsal(a):

Hi Iwai-san, Mark
Cc Sakamoto-san, Amadeusz, Pierre-Louis

It seems we can use _Generic() more simply, v2 RFC is using it.
I'm not 100% sure but unfortunately we can't use bit-field with _Generic()
in gcc (clang seems possible to handle it ?).
pci/ac97 is the only user of bit-field direction.

To avoid posting patch-bomb, I will post main patch and some sample patches
as RFC. Please review it.

Link: https://lore.kernel.org/r/87zfqel1g7.wl-kuninori.morimoto.gx@xxxxxxxxxxx

Thank you for your help !!

Hi,

my opinion is that this massive patch-set is just an overdesign. Even using the _Generic macro does not bring anything new and the code readability is not improved. If we add such macros for all simple cases (condition expressions), the code will be unreadable at some point.

					Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux