On Fri, 19 Jul 2024 04:29:56 +0200, wangdicheng wrote: > > From: wangdicheng <wangdicheng@xxxxxxxxxx> > > Sonix HD USB Camera does not support reading the sample rate which leads > to many lines of "cannot get freq at ep 0x84". > This patch adds the USB ID to quirks.c and avoids those error messages. > > (snip) > [1.789698] usb 3-3: new high-speed USB device number 2 using xhci_hcd > [1.984121] usb 3-3: New USB device found, idVendor=0c45, idProduct=6340, bcdDevice= 0.00 > [1.984124] usb 3-3: New USB device strings: Mfr=2, Product=1, SerialNumber=0 > [1.984127] usb 3-3: Product: USB 2.0 Camera > [1.984128] usb 3-3: Manufacturer: Sonix Technology Co., Ltd. > [5.440957] usb 3-3: 3:1: cannot get freq at ep 0x84 > [12.130679] usb 3-3: 3:1: cannot get freq at ep 0x84 > [12.175065] usb 3-3: 3:1: cannot get freq at ep 0x84 > > Signed-off-by: wangdicheng <wangdicheng@xxxxxxxxxx> > --- > sound/usb/quirks.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 09712e61c606..c1fd690cbac0 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -2033,6 +2033,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { > QUIRK_FLAG_GENERIC_IMPLICIT_FB), > DEVICE_FLG(0x0499, 0x3108, /* Yamaha YIT-W12TX */ > QUIRK_FLAG_GET_SAMPLE_RATE), > + DEVICE_FLG(0x0c45, 0x6340, /* Sonix HD USB Camera */ > + QUIRK_FLAG_GET_SAMPLE_RATE), > DEVICE_FLG(0x04d8, 0xfeea, /* Benchmark DAC1 Pre */ > QUIRK_FLAG_GET_SAMPLE_RATE), > DEVICE_FLG(0x04e8, 0xa051, /* Samsung USBC Headset (AKG) */ The table is sorted in the ID order. Could you put at the right position? thanks, Takashi