On 14/07/2024 12:02, Krzysztof Kozlowski wrote: > On 13/07/2024 11:56, Krzysztof Kozlowski wrote: >> Read temperature of the speaker and expose it via hwmon interface, which >> will be later used during calibration of speaker protection algorithms. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- >> >> Changes in v2: >> 1. Add missing dependency on HWMON for y!=m builds (kernel test robot >> report: undefined reference to >> `devm_hwmon_device_register_with_info'). >> --- >> sound/soc/codecs/Kconfig | 1 + >> sound/soc/codecs/wsa884x.c | 197 +++++++++++++++++++++++++++++++++++++ >> 2 files changed, 198 insertions(+) >> >> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig >> index 97bb69c9848d..09a0b209bc2f 100644 >> --- a/sound/soc/codecs/Kconfig >> +++ b/sound/soc/codecs/Kconfig >> @@ -2447,6 +2447,7 @@ config SND_SOC_WSA883X >> config SND_SOC_WSA884X >> tristate "WSA884X Codec" >> depends on SOUNDWIRE >> + depends on HWMON || !HWMON > > Eh, now I got build report that hwmon does not have stubs for !HWMON (by > design or missing?), so this still has compile failures. > > I think we should have (devm_)hwmon_device_register_with_info() stubs > for drivers not depending on hwmon, so I will propose a patch for that. > If that approach is accepted, no changes should be needed in this > wsa884x v2 patchset. Answering to myself: I see now that lack of !HWMON stubs for providers is rather by design and drivers use IS_REACHABLE. I'll send a v3 of this patch. Best regards, Krzysztof
