Le 14/06/2024 à 06:05, Baojun Xu a écrit :
This patch was used to add TAS2781 devices on SPI support in sound/pci/hda.
It use ACPI node descript about parameters of TAS2781 on SPI, it like:
Scope (_SB.PC00.SPI0)
{
Device (GSPK)
{
Name (_HID, "TXNW2781") // _HID: Hardware ID
Method (_CRS, 0, NotSerialized)
{
Name (RBUF, ResourceTemplate ()
{
SpiSerialBusV2 (...)
SpiSerialBusV2 (...)
}
}
}
}
And in platform/x86/serial-multi-instantiate.c, those spi devices will be
added into system as a single SPI device, so TAS2781 SPI driver will
probe twice for every single SPI device. And driver will also parser
mono DSP firmware binary and RCA binary for itself.
The code support Realtek as the primary codec.
Signed-off-by: Baojun Xu <baojun.xu@xxxxxx>
---
Hi,
not a must-have but using "checkpatch.pl --strict" could slightly
improve readability in some places.
Maybe at least,
- ./scripts/checkpatch.pl --strict --test-only=Blank
--> to save a few LoC
- ./scripts/checkpatch.pl --strict --test-only=parentheses
--> to improve readability and reduce the length of some lines
This is already v8, so feel free to just ignore this mail and the
--strict option.
CJ
