On Tue, Jun 11, 2024 at 12:36 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > > +FREESCALE SOC LPC32XX SOUND DRIVERS > > +M: Piotr Wojtaszczyk <piotr.wojtaszczyk@xxxxxxxxxxx> > > +L: alsa-devel@xxxxxxxxxxxxxxxx (moderated for non-subscribers) > > +L: linuxppc-dev@xxxxxxxxxxxxxxxx > > +S: Orphan > > +F: sound/soc/fsl/lpc3xxx-* > > + > > It seems a bit odd to add yourself as a maintainer while also marking > the driver as orphan? Nautel Ltd agreed to maintain this driver, I will add them. > > + i2s_info_p->clk = devm_clk_get(dev, "i2s_clk"); > > + if (IS_ERR(i2s_info_p->clk)) > > + return dev_err_probe(dev, PTR_ERR(i2s_info_p->clk), "Can't get clock\n"); > > + > > + i2s_info_p->clkrate = clk_get_rate(i2s_info_p->clk); > > + if (i2s_info_p->clkrate == 0) > > + return dev_err_probe(dev, -EINVAL, "Invalid returned clock rate\n"); > > Nothing ever enables this clock. It's enabled in lpc3xxx_i2s_startup() and disabled in lpc3xxx_i2s_shutdown(). When the clock is enabled the bit clock on I2S interface always runs. So this is to avoid active clock when the interface isn't used. -- Piotr Wojtaszczyk Timesys
