Re: [PATCH 2/5] ASoC: SOF: Intel: add initial support for PTL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 6/12/24 18:08, Pierre-Louis Bossart wrote:
> 
> 
> On 6/12/24 18:01, Mark Brown wrote:
>> On Wed, Jun 12, 2024 at 08:58:55AM +0200, Pierre-Louis Bossart wrote:
>>> Clone LNL for now.
>>
>> There's a dependency somewhere I think:
>>
>> In file included from /build/stage/linux/sound/soc/sof/intel/pci-ptl.c:10:
>> /build/stage/linux/include/linux/pci.h:1063:51: error: ‘PCI_DEVICE_ID_INTEL_HDA_
>> PTL’ undeclared here (not in a function); did you mean ‘PCI_DEVICE_ID_INTEL_HDA_
>> MTL’?
>>  1063 |         .vendor = PCI_VENDOR_ID_##vend, .device = PCI_DEVICE_ID_##vend##
>> _##dev, \
>>       |                                                   ^~~~~~~~~~~~~~
>> /build/stage/linux/sound/soc/sof/intel/pci-ptl.c:52:11: note: in expansion of ma
>> cro ‘PCI_DEVICE_DATA’
>>    52 |         { PCI_DEVICE_DATA(INTEL, HDA_PTL, &ptl_desc) }, /* PTL */>       |           ^~~~~~~~~~~~~~~
> 
> Yes indeed there is a dependency, I mentioned it in the cover letter
> 
> 
> "
> This patchset depends on the first patch of "[PATCH 0/3] ALSA/PCI: add
> PantherLake audio support"
> "
> 
> We don't add PCI IDs every week but when we do we'll need an update of
> pci_ids.h prior to ALSA- and ASoC-specific patches.

There's another problem reported by the Intel build bot

https://lore.kernel.org/oe-kbuild-all/202406131144.L6gW0I47-lkp@xxxxxxxxx/

When I modified the order of patches I broke the intermediate
compilation. The ACPI machine definition needs to come first.
I'll send a v2, sorry about that.



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux