On 11/06/2024 17:12, Mark Brown wrote:
On Tue, Jun 11, 2024 at 03:57:46PM +0100, Richard Fitzgerald wrote:If the ASP1 DAI is hooked up by the machine driver the ASP TX mixer sources should be initialized to disconnected. The silicon default is for the mixer source registers to default to a collection of monitoring sources. The problem with this is that it causes the DAPM graph to initialize with the capture path connected to a valid source widget, even though nothing setup a path. When the ASP DAI is connected as a codec-to-codec link this will cause the other codec to power-up even though nothing is using it. Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx> Fixes: dfd2ffb37399 ("ASoC: cs35l56: Prevent overwriting firmware ASP config")This doesn't seem particularly different to any other unhelpful chip default, I'm not sure why it'd be so urgent that we'd hard code a
I'm not sure I understand the objection here. Are you objecting to the patch itself, or that I marked it as a Fixes?
default? There were some other devices with things like bypass routes set up. The capture path getting spuriously triggered feels like something that should just be sorted in general (TBH I thought that worked OK but it's been quite some time since I looked properly).
