On 06/06/2024 09:45, Krzysztof Kozlowski wrote: > On 05/06/2024 18:23, Neil Armstrong wrote: >> Convert text bindings to dt-schema format for the Amlogic TX HDMI >> control glue. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > > subject: dt-bindings (missing 's') > >> --- >> .../bindings/sound/amlogic,g12a-tohdmitx.txt | 58 ---------------------- >> .../bindings/sound/amlogic,g12a-tohdmitx.yaml | 56 +++++++++++++++++++++ >> 2 files changed, 56 insertions(+), 58 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt b/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt >> deleted file mode 100644 >> index 4e8cd7eb7cec..000000000000 >> --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt >> +++ /dev/null >> @@ -1,58 +0,0 @@ >> -* Amlogic HDMI Tx control glue >> - > >> + >> +title: Amlogic G12a HDMI TX Control Glue >> + >> +maintainers: >> + - Jerome Brunet <jbrunet@xxxxxxxxxxxx> >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + $nodename: >> + pattern: "^audio-controller@.*" >> + >> + "#sound-dai-cells": >> + const: 1 >> + >> + compatible: >> + oneOf: >> + - items: >> + - const: amlogic,g12a-tohdmitx >> + - items: >> + - enum: >> + - amlogic,sm1-tohdmitx >> + - const: amlogic,g12a-tohdmitx >> + >> + reg: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> + sound-name-prefix: true > > Drop > >> + >> +required: >> + - "#sound-dai-cells" >> + - compatible >> + - reg >> + - resets > > Please keep the same order as in "properties:" block. > >> + >> +additionalProperties: false > > and here instead: > unevaluatedProperties: false > and with above changes: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
