On Mon 13 May 2024 at 00:31, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > Hi Mark, Pierre-Louis, Jerome > Cc each ASoC driver maintainer > > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > so we remove it. But we have been using it for 10 years, some driver might > get damage. The most likely case is that the device/driver can use both > playback/capture, but have only one flag, and not using xxx_only flag. > [1/3] patch indicates warning in such case. > > And because of its history, DPCM has been checking CPU side only. But it should > check Codec side too same as non-DPCM. Some device/driver has been bypassed > this check. It should be error. [2/3] patch indicates warning in such case. > > Because dpcm_xxx flag is no longer used by [1/3] patch, > snd_soc_dai_link_set_capabilities() is no longer needed. [3/3] patch remove it. > > These adds grace time for DPCM cleanup. > I'm not sure when dpcm_xxx will be removed, and Codec check bypass will be error, > but maybe v6.11 or v6.12 ? > Please check each driver by that time. > > [1] https://lore.kernel.org/r/87edaym2cg.wl-kuninori.morimoto.gx@xxxxxxxxxxx > > Link: https://lore.kernel.org/r/87edaym2cg.wl-kuninori.morimoto.gx@xxxxxxxxxxx > Link: https://lore.kernel.org/r/87wmo6dyxg.wl-kuninori.morimoto.gx@xxxxxxxxxxx > > v1 -> v2 > - tidyup Codec check warning output condition > > Kuninori Morimoto (3): > ASoC: soc-pcm: Indicate warning if dpcm_playback/capture were used for availability limition > ASoC: soc-pcm: Indicate warning if CPU / Codec availability mismatch > ASoC: remove snd_soc_dai_link_set_capabilities() For Amlogic, with the change sent as RFC on this series. Tested-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > > include/sound/soc-dai.h | 1 - > include/sound/soc.h | 1 + > sound/soc/fsl/imx-card.c | 3 - > sound/soc/generic/audio-graph-card.c | 2 - > sound/soc/generic/audio-graph-card2.c | 2 - > sound/soc/generic/simple-card.c | 2 - > sound/soc/meson/axg-card.c | 1 - > sound/soc/meson/gx-card.c | 1 - > sound/soc/qcom/common.c | 1 - > sound/soc/soc-dai.c | 38 --------- > sound/soc/soc-pcm.c | 110 +++++++++++++++++++------- > 11 files changed, 81 insertions(+), 81 deletions(-) -- Jerome
