Hi Andy Thanks for your comment. > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Sent: Monday, May 13, 2024 6:00 PM > To: Ding, Shenghao <shenghao-ding@xxxxxx> > Cc: broonie@xxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre- > louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; alsa-devel@alsa- > project.org; linux-kernel@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxx; > bard.liao@xxxxxxxxx; yung-chuan.liao@xxxxxxxxxxxxxxx; Lu, Kevin <kevin- > lu@xxxxxx>; cameron.berkenpas@xxxxxxxxx; tiwai@xxxxxxx; Xu, Baojun > <baojun.xu@xxxxxx>; soyer@xxxxxx; Baojun.Xu@xxxxxxx > Subject: [EXTERNAL] Re: [PATCH v5 2/3] ASoC: tas2781: Fix wrong loading > calibrated data sequence > > On Sun, May 12, 2024 at 10:50:38AM +0800, Shenghao Ding wrote: > > Calibrated data will be set to default after loading DSP config > > params, which will cause speaker protection work abnormally. Reload > > calibrated data after loading DSP config params. > > ... > > > -int tasdevice_prmg_calibdata_load(void *context, int prm_no) > > > -EXPORT_SYMBOL_NS_GPL(tasdevice_prmg_calibdata_load, > > - SND_SOC_TAS2781_FMWLIB); > > AFAICS the i2c glue driver still uses this, how can't this break the build? [PATCH v5 3/3] has removed tasdevice_prmg_calibdata_load, and tasdevice_prmg_load(tas_priv, 0) has been called instead of tasdevice_prmg_calibdata_load > > -- > With Best Regards, > Andy Shevchenko >
