On Wed, 08 May 2024 12:08:11 +0200,
Richard Fitzgerald wrote:
>
> The cs_dsp instance is initialized in the driver probe() so it
> should be freed in the driver remove(). Also fix a missing call
> to cs_dsp_remove() in the error path of cs35l56_hda_common_probe().
>
> The call to cs_dsp_remove() was being done in the component unbind
> callback cs35l56_hda_unbind(). This meant that if the driver was
> unbound and then re-bound it would be using an uninitialized cs_dsp
> instance.
>
> It is best to initialize the cs_dsp instance in probe() so that it
> can return an error if it fails. The component binding API doesn't
> have any error handling so there's no way to handle a failure if
> cs_dsp was initialized in the bind.
>
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Applied now. Thanks.
Takashi
