Re: [PATCH] ALSA: hda: intel-sdw-acpi: fix usage of device_get_named_child_node()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 29 Apr 2024 17:15:19 +0200,
Pierre-Louis Bossart wrote:
> 
> Hi Takashi,
> 
> >> The documentation for device_get_named_child_node() mentions this
> >> important point:
> >>
> >> "
> >> The caller is responsible for calling fwnode_handle_put() on the
> >> returned fwnode pointer.
> >> "
> >>
> >> Add fwnode_handle_put() to avoid a leaked reference.
> >>
> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> > 
> > Can we have a corresponding Fixes tag?
> 
> Good question.
> 
> The initial code was in
> 
> 6d2c66695bf3 ("soundwire: intel: transition to 3 steps initialization")
> 
> but then moved with
> 
> 08c2a4bc9f2a ("ALSA: hda: move Intel SoundWire ACPI scan to dedicated
> module")
> 
> I guess a Fixes tag for the latter is good enough, it's a 2021 commit
> and that would probably cover most SoundWire platforms.

OK, let's take it, then.  Applied now.


thanks,

Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux