Hi Jerome > >> unsigned int directions; > >> #define PLAYBACK_VALID BIT(0) > >> #define CAPTURE_VALID BIT(1) > > > > I think Amadeusz indicated similar idea, and basically I can agree about > > it. > > I've seen it afterward. It is similar indeed but I don't think 'None' or > 'Both' should have a dedicated bit. That would be yet another > redundance/implication between flags/bits ... so another source of > bugs/complexity IMO. I noticed that it is alreay using bitfield. The diff is it is possible to use "XXX | YYY" style or not. /* For unidirectional dai links */ unsigned int playback_only:1; unsigned int capture_only:1; ... /* DPCM capture and Playback support */ unsigned int dpcm_capture:1; unsigned int dpcm_playback:1; Thank you for your help !! Best regards --- Renesas Electronics Ph.D. Kuninori Morimoto