> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > Sent: 26 March 2024 23:05 > To: Xu, Baojun; tiwai@xxxxxxx > Cc: robh+dt@xxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; Lu, Kevin; 13916275206@xxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxx; yung-chuan.liao@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxx; soyer@xxxxxx > Subject: [EXTERNAL] Re: [PATCH v1 6/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver > > > +enum device_catlog_id { > > catalog? > > > + HP = 0, > > + OTHERS > > +}; > > Is there not a better way to identify solutions? > You have ACPI IDs, no? It support HP platform now only, will add other later. Best Regards Jim