On Mon, 01 Apr 2024 16:58:05 +0200, Oswald Buddenhagen wrote: > > As already anticipated in the original commit, playback was broken for > very short samples. I just didn't expect it to be an actual problem, > because we're talking about less than 1.5 milliseconds here. But clearly > such wavetable samples do actually exist. > > The problem was that for such short samples we'd set the current > position beyond the end of the loop, so we'd run off the end of the > sample and play garbage. > This is a bigger (more audible) problem than the original one, which was > that we'd start playback with garbage (whatever was still in the cache), > which would be mostly masked by the note's attack phase. > > So revert to the old behavior for now. We'll subsequently fix it > properly with a bigger patch series. > Note that this isn't a full revert - the dead code is not re-introduced, > because that would be silly. > > Fixes: df335e9a8b (ALSA: emu10k1: fix synthesizer sample playback position and caching, 2023-05-18) > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218625 > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> Thanks, applied now. Takashi
