Re: [PATCH] ALSA: aaci: report FIFO size in frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] ALSA: aaci: report FIFO size in frames
From: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx>
Date: Mon, 1 Apr 2024 12:53:18 +0200
Cc: alsa-devel@xxxxxxxxxxxxxxxx, Takashi Iwai <tiwai@xxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>
In-reply-to: <ZgqOZ0B8h3l48aoh@shell.armlinux.org.uk>
References: <20240401101339.506625-1-oswald.buddenhagen@gmx.de> <ZgqNFjOU4mpcyHH8@shell.armlinux.org.uk> <ZgqOZ0B8h3l48aoh@shell.armlinux.org.uk>
Ui-outboundreport: notjunk:1;M01:P0:7ctv/T8clqU=;b+KFrxJQItXkXrFK9OEdbfzxFrP EAFg7oeiwOaMM3AGBr77b/HTndIHhNIzSAQwt86ZmFFu/EBbQSM2L21fPcL3SIBkdWvocp29n bTFC5xk1SMUswwz661m2H51EqoD3av66PYHMEszDN+zBKoWx3SrMfhQcC8GfmjP1BOz3/LqkQ YGJQGLycWah0BMkDDVcOgTMht+qq96RzEaUUd9nddIkIAmpdBTIR16/6S0flfov3iykFU05Ve hf1Kz2hnialw3ChedtdUMaZ/Rz3sg8kq5323ytDt2B0XUYu4tzEx38yJ/49TIHEFKfNJiLeaE sQCEVBolH70VEU1bVoR/fCq0BCC/2bVThBfv76Q5vq7xdBfT7od876dD96axAT33po0Vc6Ws0 2NE+j0cB/OoC/o+fgxaBNZhGggmj/A9QqFlh2+L/3mxwj6eB5Dt1yq3kAGGvXd1wZUlQlqV73 sUtXhlSkN1/cOUD9Pc8ZhmbFypHXyO9WCTz8jUEp1r0mWDFxApExqelqzoLE8Q6aZPGyhBQW1 YrgamKes50hIUF+CJP8G368WEPGumeqFC27R5LY9sR6LA2Deq+I+OIeVqhUbjrpExBRI8rA5a VMfrj7z2pgQM3e5XKTdUe1YQ0/turUFHJCYIFcxx4gdbK/QVOlQwbu2gi+P9+DyFM0I+D3dZ1 wJ+m2XxKl4B8+CWOdHxLlJS47x8XG3m1XzemCclPje51c2G50wnCpm71E03GOYjtSbLozGSlK eYGBe5qJT3GrmRjuQQdaGSjZw22e+TaTnUvvk7D6gGm1gL4xnShlsphIcy1hGSiEPcOLlo0Jj IQopkgogaHsDbahHDB0ZK/+pJNg1oVMgg/7i3kRVG4Fg8=

On Mon, Apr 01, 2024 at 11:37:27AM +0100, Russell King (Oracle) wrote:

runtime->hw.fifo_size is only measured in _frames_ if
SNDRV_PCM_INFO_FIFO_IN_FRAMES is set.

yes, which is exactly why the other hunk in the patch sets it.

So now I have to ask what caused you to generate this patch. I don't
think you've actually run this driver, so presumably it's by []
code inspection...

yes, it was a random find while trying to make sense of this parameter.

Follow-Ups:
- Re: [PATCH] ALSA: aaci: report FIFO size in frames
  - From: Russell King (Oracle)

References:
- [PATCH] ALSA: aaci: report FIFO size in frames
  - From: Oswald Buddenhagen
- Re: [PATCH] ALSA: aaci: report FIFO size in frames
  - From: Russell King (Oracle)
- Re: [PATCH] ALSA: aaci: report FIFO size in frames
  - From: Russell King (Oracle)

Prev by Date: Re: [PATCH] ALSA: soc/au1x: declare that FIFO is reported in frames
Next by Date: Re: [PATCH] ALSA: aaci: report FIFO size in frames
Previous by thread: Re: [PATCH] ALSA: aaci: report FIFO size in frames
Next by thread: Re: [PATCH] ALSA: aaci: report FIFO size in frames
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]